abhishekrb19 commented on code in PR #15018:
URL: https://github.com/apache/druid/pull/15018#discussion_r1332261250
##########
extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/InlineSchemaAvroBytesDecoder.java:
##########
@@ -88,7 +88,6 @@ public GenericRecord parse(ByteBuffer bytes)
return reader.read(null, DecoderFactory.get().binaryDecoder(inputStream,
null));
}
catch (EOFException eof) {
- // waiting for avro v1.9.0 (#AVRO-813)
Review Comment:
Unfortunately, the error still appears in 1.11.1 sporadically - that's how I
stumbled into this stale comment trying to find the source of exception. Not
sure what the cause is though. Reading through the
[issue](https://issues.apache.org/jira/browse/AVRO-813) and other related
forums, it seems like `EOFException` can still occur in legitimate scenarios
where a producer didn't close a file descriptor correctly or when there's a
connection reset. Perhaps the `ParseException` could add some more details?
##########
extensions-core/avro-extensions/src/main/java/org/apache/druid/data/input/avro/InlineSchemaAvroBytesDecoder.java:
##########
@@ -88,7 +88,6 @@ public GenericRecord parse(ByteBuffer bytes)
return reader.read(null, DecoderFactory.get().binaryDecoder(inputStream,
null));
}
catch (EOFException eof) {
- // waiting for avro v1.9.0 (#AVRO-813)
Review Comment:
Unfortunately, the error still appears in 1.11.1 sporadically - that's how I
stumbled into this stale comment trying to find the source of exception. Not
sure what the cause is though. Reading through the
[issue](https://issues.apache.org/jira/browse/AVRO-813) and other related
forums, it seems like `EOFException` can still occur in legitimate scenarios
where a producer didn't close a file descriptor correctly or when there's a
connection reset. Perhaps the `ParseException` could add some more details?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
