kfaraz commented on code in PR #15021:
URL: https://github.com/apache/druid/pull/15021#discussion_r1332478424
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTaskTest.java:
##########
@@ -59,7 +59,7 @@ public void testKill() throws Exception
newSegment(Intervals.of("2019-03-01/2019-04-01"), version),
newSegment(Intervals.of("2019-04-01/2019-05-01"), version)
);
- final Set<DataSegment> announced =
getMetadataStorageCoordinator().announceHistoricalSegments(segments);
+ final Set<DataSegment> announced =
getMetadataStorageCoordinator().commitSegments(segments);
Review Comment:
Sure 👍🏻
If CI fails for any reason, I will include this change. Otherwise, I will
include it in the other PR.
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTaskTest.java:
##########
@@ -59,7 +59,7 @@ public void testKill() throws Exception
newSegment(Intervals.of("2019-03-01/2019-04-01"), version),
newSegment(Intervals.of("2019-04-01/2019-05-01"), version)
);
- final Set<DataSegment> announced =
getMetadataStorageCoordinator().announceHistoricalSegments(segments);
+ final Set<DataSegment> announced =
getMetadataStorageCoordinator().commitSegments(segments);
Review Comment:
Sure 👍🏻
If CI fails for any reason, I will include this change. Otherwise, I will
include it in the other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
