kgyrtkirk commented on code in PR #15005: URL: https://github.com/apache/druid/pull/15005#discussion_r1332571252
########## sql/src/test/java/org/apache/druid/sql/calcite/DecoupledIgnore.java: ########## @@ -0,0 +1,111 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite; + +import com.google.common.base.Throwables; +import org.apache.druid.error.DruidException; +import org.junit.AssumptionViolatedException; +import org.junit.rules.TestRule; +import org.junit.runner.Description; +import org.junit.runners.model.Statement; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + +import static org.junit.Assert.assertThrows; + +/** + * Can be used to mark tests which are not-yet supported in decoupled mode. + * + * In case a testcase marked with this annotation fails - it may mean that the + * testcase no longer needs that annotation. + */ +@Retention(RetentionPolicy.RUNTIME) +@Target({ElementType.METHOD}) +public @interface DecoupledIgnore +{ + Modes mode() default Modes.NOT_ENOUGH_RULES; + + enum Modes + { + PLAN_MISMATCH(AssertionError.class, "AssertionError: query #"), + NOT_ENOUGH_RULES(DruidException.class, "not enough rules"), + CANNOT_CONVERT(DruidException.class, "Cannot convert query parts"), + ERROR_HANDLING(AssertionError.class, "(is <ADMIN> was <OPERATOR>|is <INVALID_INPUT> was <UNCATEGORIZED>|with message a string containing)"); + + public Class<? extends Throwable> throwableClass; + public String regex; + + Modes(Class<? extends Throwable> cl, String regex) + { + this.throwableClass = cl; + this.regex = regex; + } + + Pattern getPattern() + { + return Pattern.compile(regex); Review Comment: Actually that was my intention when I've introduced this method - but I've forgot it. The current patterns doesn't seem to be that costly; can we make this change later - when we add more patterns/etc; its hard to get clear testruns nowadays... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
