LakshSingla commented on code in PR #14994:
URL: https://github.com/apache/druid/pull/14994#discussion_r1332641725
##########
processing/src/main/java/org/apache/druid/frame/Frame.java:
##########
@@ -105,7 +105,7 @@ public class Frame
private final int numRegions;
private final boolean permuted;
- private Frame(Memory memory, FrameType frameType, long numBytes, int
numRows, int numRegions, boolean permuted)
+ protected Frame(Memory memory, FrameType frameType, long numBytes, int
numRows, int numRegions, boolean permuted)
Review Comment:
```suggestion
private Frame(Memory memory, FrameType frameType, long numBytes, int
numRows, int numRegions, boolean permuted)
```
Please revert this change. We shouldn't change the access level in the main
class to allow testing. At worst, we can mock the class in the tests, but if we
do want to assert something that won't ever be possible and we are setting up a
defensive check for the same.
We are basically annotating the constructor here with @VisibleForTesting,
without mentioning it
https://github.com/apache/druid/pull/11848#discussion_r739022142
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
