zachjsh commented on code in PR #15023:
URL: https://github.com/apache/druid/pull/15023#discussion_r1333441247
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTaskTest.java:
##########
@@ -99,8 +103,9 @@ public void testKill() throws Exception
newSegment(Intervals.of("2019-04-01/2019-05-01"), version)
);
- Assert.assertEquals(2L, task.getNumBatchesProcessed());
- Assert.assertEquals(1, task.getNumSegmentsKilled());
+ KillTaskReport.Stats stats = getReportedStats();
+ Assert.assertEquals(2, stats.getNumBatchesProcessed());
Review Comment:
nit: could create an expected KillTaskReport.Stats object, and check for
equality in one call, rather than for each member. Similar for other tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
