georgew5656 opened a new pull request, #15041: URL: https://github.com/apache/druid/pull/15041
This fix attempts to bring the KubernetesTaskRunner more into line with the HttpRemoteTaskRunner (https://github.com/apache/druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/overlord/hrtr/HttpRemoteTaskRunner.java#L560) w.r.t startup initialization. Right now when the overlord becomes a leader using the KubernetesTaskRunner it adds all of the running tasks to its mapping, but doesn't wait for the underlying thread pool to finish syncing state from Kubernetes. This change attempts to do this (although it doesn't fail if it is unable to completely finish syncing) ### Description Best-effort attempt to sync state from Kubernetes completely before becoming the overlord leader when running mm-less ingestion. In the start() method, after adding all the jobs in kubernetes to the tasks map, try to wait for the underlying thread pool to finish syncing state from K8s. #### Release note Improvments to overlord lifecycle when running mm-less ingestion ##### Key changed/added classes in this PR * `KubernetesTaskRunner` <hr> <!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. --> This PR has: - [X] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [X] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
