This is an automated email from the ASF dual-hosted git repository.
karan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new fc929e6d25f upgrade shade (#15042)
fc929e6d25f is described below
commit fc929e6d25f79da8596dec35669ae6ec981f2372
Author: George Shiqi Wu <[email protected]>
AuthorDate: Wed Sep 27 08:49:21 2023 -0400
upgrade shade (#15042)
Upgrade maven shade plugin to try to fix build failures
Sometimes we get maven shade errors in our integ tests becasue we don't run
clean in between runs to clear the cache in order to speed them up. This can
lead to the below error.
Error: Failed to execute goal
org.apache.maven.plugins:maven-shade-plugin:3.2.4:shade
(opentelemetry-extension) on project opentelemetry-emitter: Error creating
shaded jar: duplicate entry:
META-INF/services/org.apache.druid.opentelemetry.shaded.io.grpc.NameResolverProvider
See:
https://issues.apache.org/jira/projects/MSHADE/issues/MSHADE-425?filter=allissues
An example run that failed:
https://github.com/apache/druid/actions/runs/6301662092/job/17117142375?pr=14887
According to the ticket this is fixed by updating shade to 3.4.1.
When I updated to 3.4.1 I kept running into a different issue during static
checks. (Caused by: java.lang.NoClassDefFoundError:
com/github/rvesse/airline/parser/errors/ParseException)
I had to add the createDependencyReducedPom: false to get the build to pass.
The dependency reduced pom feature was added in 3.3.0 which we were not
using before so setting it explicitly to false should not be a issue.
https://issues.apache.org/jira/browse/MSHADE-36)
---
extensions-core/protobuf-extensions/pom.xml | 2 +-
pom.xml | 5 ++++-
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/extensions-core/protobuf-extensions/pom.xml
b/extensions-core/protobuf-extensions/pom.xml
index e93de914ccd..1f267b51754 100644
--- a/extensions-core/protobuf-extensions/pom.xml
+++ b/extensions-core/protobuf-extensions/pom.xml
@@ -187,7 +187,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.1</version>
+ <version>3.4.1</version>
<configuration>
<createDependencyReducedPom>true</createDependencyReducedPom>
<relocations>
diff --git a/pom.xml b/pom.xml
index 172bd90919d..3f2dddfb2bb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1730,7 +1730,10 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-shade-plugin</artifactId>
- <version>3.2.4</version>
+ <version>3.4.1</version>
+ <configuration>
+
<createDependencyReducedPom>false</createDependencyReducedPom>
+ </configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
