xvrl commented on code in PR #15042:
URL: https://github.com/apache/druid/pull/15042#discussion_r1340692264


##########
pom.xml:
##########
@@ -1730,7 +1730,10 @@
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>
                     <artifactId>maven-shade-plugin</artifactId>
-                    <version>3.2.4</version>
+                    <version>3.4.1</version>
+                    <configuration>
+                        
<createDependencyReducedPom>false</createDependencyReducedPom>
+                    </configuration>

Review Comment:
   any reason we are setting this globally instead of defining it where we 
actually use the plugin?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to