github-code-scanning[bot] commented on code in PR #14981: URL: https://github.com/apache/druid/pull/14981#discussion_r1340699154
########## sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidFreeUnionDataSourceRule.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.rule; + +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Union; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.apache.druid.sql.calcite.rel.DruidFreeUnionDataSourceRel; +import org.apache.druid.sql.calcite.rel.DruidRel; + +import javax.annotation.Nullable; +import java.util.Collections; +import java.util.List; +import java.util.Optional; + +/** + * Creates a {@link DruidFreeUnionDataSourceRel} from various {@link DruidRel} inputs that represents ad hoc scans + * + */ +public class DruidFreeUnionDataSourceRule extends RelOptRule +{ + private final PlannerContext plannerContext; + + public DruidFreeUnionDataSourceRule(final PlannerContext plannerContext) + { + super( + operand( + Union.class, + operand(DruidRel.class, none()), + operand(DruidRel.class, none()) + ) + ); + this.plannerContext = plannerContext; + } + + @Override + public boolean matches(RelOptRuleCall call) + { + final Union unionRel = call.rel(0); + final DruidRel<?> firstDruidRel = call.rel(1); + final DruidRel<?> secondDruidRel = call.rel(2); + + return isCompatible(unionRel, firstDruidRel, secondDruidRel, plannerContext); + } + + @Override + public void onMatch(final RelOptRuleCall call) + { + final Union unionRel = call.rel(0); + final DruidRel<?> firstDruidRel = call.rel(1); + final DruidRel<?> secondDruidRel = call.rel(2); + + if (firstDruidRel instanceof DruidFreeUnionDataSourceRel) { + // Unwrap and flatten the inputs to the Union. + final RelNode newUnionRel = call.builder() + .pushAll(firstDruidRel.getInputs()) + .push(secondDruidRel) + .union(true, firstDruidRel.getInputs().size() + 1) + .build(); + + call.transformTo( + DruidFreeUnionDataSourceRel.create( + (Union) newUnionRel, + getColumnNames(firstDruidRel, plannerContext).get(), + firstDruidRel.getPlannerContext() + ) + ); + } else { + call.transformTo( + DruidFreeUnionDataSourceRel.create( + unionRel, + getColumnNames(firstDruidRel, plannerContext).get(), + firstDruidRel.getPlannerContext() + ) + ); + } + } + + // Can only do UNION ALL of inputs that have compatible schemas (or schema mappings) and right side + // is a simple table scan + public static boolean isCompatible( + final Union unionRel, + final DruidRel<?> first, + final DruidRel<?> second, + @Nullable PlannerContext plannerContext + ) + { + if (second instanceof DruidFreeUnionDataSourceRel) { + return false; + } + + if (!unionRel.all && null != plannerContext) { + plannerContext.setPlanningError("SQL requires 'UNION' but only 'UNION ALL' is supported."); + } + return unionRel.all && isUnionCompatible(first, second, plannerContext); + } + + /** + * For the current implementation the union is compatible iff the column's data types column and names are same + */ + private static boolean isUnionCompatible( + final DruidRel<?> first, + final DruidRel<?> second, + @Nullable PlannerContext plannerContext + ) + { + final Optional<List<String>> firstColumnNames = getColumnNames(first, plannerContext); + final Optional<List<String>> secondColumnNames = getColumnNames(second, plannerContext); + if (!firstColumnNames.isPresent() || !secondColumnNames.isPresent()) { + // No need to set the planning error here + return false; + } + if (!firstColumnNames.equals(secondColumnNames)) { + if (null != plannerContext) { + plannerContext.setPlanningError( + "SQL requires union between two tables and column names queried for " + + "each table are different Left: %s, Right: %s.", + firstColumnNames.orElse(Collections.emptyList()), + secondColumnNames.orElse(Collections.emptyList()) + ); + } + return false; + } + return true; + } + + static Optional<List<String>> getColumnNames(final DruidRel<?> druidRel, @Nullable PlannerContext plannerContext) Review Comment: ## Useless parameter The parameter 'plannerContext' is never used. [Show more details](https://github.com/apache/druid/security/code-scanning/5830) ########## sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidFreeUnionDataSourceRule.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.rule; + +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Union; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.apache.druid.sql.calcite.rel.DruidFreeUnionDataSourceRel; +import org.apache.druid.sql.calcite.rel.DruidRel; + +import javax.annotation.Nullable; +import java.util.Collections; +import java.util.List; +import java.util.Optional; + +/** + * Creates a {@link DruidFreeUnionDataSourceRel} from various {@link DruidRel} inputs that represents ad hoc scans + * + */ +public class DruidFreeUnionDataSourceRule extends RelOptRule +{ + private final PlannerContext plannerContext; + + public DruidFreeUnionDataSourceRule(final PlannerContext plannerContext) + { + super( + operand( + Union.class, + operand(DruidRel.class, none()), Review Comment: ## Deprecated method or constructor invocation Invoking [RelOptRule.operand](1) should be avoided because it has been deprecated. [Show more details](https://github.com/apache/druid/security/code-scanning/5832) ########## sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidFreeUnionDataSourceRule.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.rule; + +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Union; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.apache.druid.sql.calcite.rel.DruidFreeUnionDataSourceRel; +import org.apache.druid.sql.calcite.rel.DruidRel; + +import javax.annotation.Nullable; +import java.util.Collections; +import java.util.List; +import java.util.Optional; + +/** + * Creates a {@link DruidFreeUnionDataSourceRel} from various {@link DruidRel} inputs that represents ad hoc scans + * + */ +public class DruidFreeUnionDataSourceRule extends RelOptRule +{ + private final PlannerContext plannerContext; + + public DruidFreeUnionDataSourceRule(final PlannerContext plannerContext) + { + super( + operand( + Union.class, + operand(DruidRel.class, none()), + operand(DruidRel.class, none()) + ) Review Comment: ## Deprecated method or constructor invocation Invoking [RelOptRule.operand](1) should be avoided because it has been deprecated. [Show more details](https://github.com/apache/druid/security/code-scanning/5831) ########## sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidFreeUnionDataSourceRule.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.rule; + +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Union; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.apache.druid.sql.calcite.rel.DruidFreeUnionDataSourceRel; +import org.apache.druid.sql.calcite.rel.DruidRel; + +import javax.annotation.Nullable; +import java.util.Collections; +import java.util.List; +import java.util.Optional; + +/** + * Creates a {@link DruidFreeUnionDataSourceRel} from various {@link DruidRel} inputs that represents ad hoc scans + * + */ +public class DruidFreeUnionDataSourceRule extends RelOptRule +{ + private final PlannerContext plannerContext; + + public DruidFreeUnionDataSourceRule(final PlannerContext plannerContext) + { + super( + operand( + Union.class, + operand(DruidRel.class, none()), + operand(DruidRel.class, none()) Review Comment: ## Deprecated method or constructor invocation Invoking [RelOptRule.operand](1) should be avoided because it has been deprecated. [Show more details](https://github.com/apache/druid/security/code-scanning/5833) ########## sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidFreeUnionDataSourceRule.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.rule; + +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Union; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.apache.druid.sql.calcite.rel.DruidFreeUnionDataSourceRel; +import org.apache.druid.sql.calcite.rel.DruidRel; + +import javax.annotation.Nullable; +import java.util.Collections; +import java.util.List; +import java.util.Optional; + +/** + * Creates a {@link DruidFreeUnionDataSourceRel} from various {@link DruidRel} inputs that represents ad hoc scans + * + */ +public class DruidFreeUnionDataSourceRule extends RelOptRule +{ + private final PlannerContext plannerContext; + + public DruidFreeUnionDataSourceRule(final PlannerContext plannerContext) + { + super( + operand( + Union.class, + operand(DruidRel.class, none()), Review Comment: ## Deprecated method or constructor invocation Invoking [RelOptRule.none](1) should be avoided because it has been deprecated. [Show more details](https://github.com/apache/druid/security/code-scanning/5834) ########## sql/src/main/java/org/apache/druid/sql/calcite/rule/DruidFreeUnionDataSourceRule.java: ########## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.rule; + +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelOptRuleCall; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.core.Union; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.apache.druid.sql.calcite.rel.DruidFreeUnionDataSourceRel; +import org.apache.druid.sql.calcite.rel.DruidRel; + +import javax.annotation.Nullable; +import java.util.Collections; +import java.util.List; +import java.util.Optional; + +/** + * Creates a {@link DruidFreeUnionDataSourceRel} from various {@link DruidRel} inputs that represents ad hoc scans + * + */ +public class DruidFreeUnionDataSourceRule extends RelOptRule +{ + private final PlannerContext plannerContext; + + public DruidFreeUnionDataSourceRule(final PlannerContext plannerContext) + { + super( + operand( + Union.class, + operand(DruidRel.class, none()), + operand(DruidRel.class, none()) Review Comment: ## Deprecated method or constructor invocation Invoking [RelOptRule.none](1) should be avoided because it has been deprecated. [Show more details](https://github.com/apache/druid/security/code-scanning/5835) ########## sql/src/main/java/org/apache/druid/sql/calcite/rel/DruidFreeUnionDataSourceRel.java: ########## @@ -0,0 +1,272 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.sql.calcite.rel; + +import com.fasterxml.jackson.core.JsonProcessingException; +import org.apache.calcite.plan.RelOptCluster; +import org.apache.calcite.plan.RelOptCost; +import org.apache.calcite.plan.RelOptPlanner; +import org.apache.calcite.plan.RelOptRule; +import org.apache.calcite.plan.RelTraitSet; +import org.apache.calcite.rel.RelNode; +import org.apache.calcite.rel.RelWriter; +import org.apache.calcite.rel.core.Union; +import org.apache.calcite.rel.metadata.RelMetadataQuery; +import org.apache.calcite.rel.type.RelDataType; +import org.apache.druid.java.util.common.StringUtils; +import org.apache.druid.query.DataSource; +import org.apache.druid.query.QueryDataSource; +import org.apache.druid.query.TableDataSource; +import org.apache.druid.query.UnionDataSource; +import org.apache.druid.segment.column.RowSignature; +import org.apache.druid.sql.calcite.planner.PlannerContext; +import org.apache.druid.sql.calcite.table.RowSignatures; + +import java.util.ArrayList; +import java.util.HashSet; +import java.util.List; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * Represents a query on top of a {@link UnionDataSource}. This is used to represent a "UNION ALL" of regular table + * datasources. + * <p> + * See {@link DruidUnionRel} for a version that can union any set of queries together (not just regular tables), + * but also must be the outermost rel of a query plan. In the future we expect that {@link UnionDataSource} will gain + * the ability to union query datasources together, and then this class could replace {@link DruidUnionRel}. + */ +public class DruidFreeUnionDataSourceRel extends DruidRel<DruidFreeUnionDataSourceRel> Review Comment: ## No clone method No clone method, yet implements Cloneable. [Show more details](https://github.com/apache/druid/security/code-scanning/5836) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
