gianm commented on code in PR #15007: URL: https://github.com/apache/druid/pull/15007#discussion_r1341562922
########## processing/src/main/java/org/apache/druid/frame/processor/manager/ProcessorManager.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.frame.processor.manager; + +import com.google.common.util.concurrent.ListenableFuture; +import org.apache.druid.frame.processor.FrameProcessorExecutor; +import org.apache.druid.java.util.common.guava.Sequence; + +import java.io.Closeable; +import java.util.Optional; +import java.util.function.BiFunction; + +/** + * Used by {@link FrameProcessorExecutor#runAllFully} to manage the launching of processors. Processors returned by + * this class may run concurrently with each other. + * + * This interface allows for simple sequences of processors, such as {@link ProcessorManagers#of(Sequence)}. It also + * allows for situations where later processors depend on the results of earlier processors. (The result of earlier + * processors are made available to the manager through {@link ProcessorAndCallback#onComplete(Object)}.) Review Comment: I added a little text about this. The idea is that `next()` returns a future, and so the future resolution can be delayed until the "earlier" processors run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
