pranavbhole commented on code in PR #14956:
URL: https://github.com/apache/druid/pull/14956#discussion_r1343200260
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -8967,6 +8967,65 @@ public void testFilterAndGroupByLookup()
)
);
}
+ @Test
+ public void testLookupReplaceMissingValueWith()
+ {
+ // Cannot vectorize due to extraction dimension specs.
+ cannotVectorize();
+
+ final RegisteredLookupExtractionFn extractionFn1 = new
RegisteredLookupExtractionFn(
+ null,
+ "lookyloo",
+ false,
+ "Missing_Value",
+ null,
+ true
+ );
+ final RegisteredLookupExtractionFn extractionFnRMVNull = new
RegisteredLookupExtractionFn(
+ null,
+ "lookyloo",
+ false,
+ null,
+ null,
+ true
+ );
+ testQuery(
+ "SELECT LOOKUP(dim1, 'lookyloo', 'Missing_Value'), LOOKUP(dim1,
'lookyloo', null) as rmvNull, COUNT(*) FROM foo group by 1,2",
+ ImmutableList.of(
+ GroupByQuery.builder()
+ .setDataSource(CalciteTests.DATASOURCE1)
+ .setInterval(querySegmentSpec(Filtration.eternity()))
+ .setGranularity(Granularities.ALL)
+ .setDimensions(
+ dimensions(
+ new ExtractionDimensionSpec(
+ "dim1",
+ "d0",
+ ColumnType.STRING,
+ extractionFn1
+ ),
+ new ExtractionDimensionSpec(
+ "dim1",
+ "d1",
+ ColumnType.STRING,
+ extractionFnRMVNull
+ )
+ )
+ )
+ .setAggregatorSpecs(
+ aggregators(
+ new CountAggregatorFactory("a0")
+ )
+ )
+ .setContext(QUERY_CONTEXT_DEFAULT)
+ .build()
+ ),
+ ImmutableList.of(
+ new Object[]{"Missing_Value", NullHandling.sqlCompatible() ? null
: "", 5L},
Review Comment:
fixed
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/builtin/QueryLookupOperatorConversion.java:
##########
@@ -91,4 +104,18 @@ public DruidExpression toDruidExpression(
}
);
}
+
+ private String getReplaceMissingValueWith(
+ final List<DruidExpression> inputExpressions,
+ final PlannerContext plannerContext
+ )
+ {
+ if (inputExpressions.size() > 2) {
+ final Expr missingValExpr =
plannerContext.parseExpression(inputExpressions.get(2).getExpression());
+ if (missingValExpr.isLiteral()) {
+ return (String) missingValExpr.getLiteralValue();
Review Comment:
fixed
##########
processing/src/main/java/org/apache/druid/query/expression/LookupExprMacro.java:
##########
@@ -69,7 +70,9 @@ public Expr apply(final List<Expr> args)
lookupExtractorFactoryContainerProvider,
lookupName,
false,
- null,
+ replaceMissingValueWith != null && replaceMissingValueWith.isLiteral()
+ ? (String) replaceMissingValueWith.getLiteralValue()
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
