kgyrtkirk commented on code in PR #15068:
URL: https://github.com/apache/druid/pull/15068#discussion_r1343973256
##########
processing/src/main/java/org/apache/druid/segment/nested/DictionaryIdLookup.java:
##########
@@ -135,7 +135,9 @@ public int lookupString(@Nullable String value)
public int lookupLong(@Nullable Long value)
{
if (longDictionary == null) {
- Path longFile = makeTempFile(name +
NestedCommonFormatColumnSerializer.LONG_DICTIONARY_FILE_NAME);
+ final Path longFile = makeTempFile(
Review Comment:
note: seems like `makeTempFile` is a class method; it could be possible to
push the `StringUtils.urlEncode(name)` into that; so that call sites could look
like:
```
makeTempFile(NestedCommonFormatColumnSerializer.LONG_DICTIONARY_FILE_NAME)
```
the method already appends `.tmp` ; so it could pick up this as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
