rohangarg commented on code in PR #15057:
URL: https://github.com/apache/druid/pull/15057#discussion_r1344089625
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteWindowQueryTest.java:
##########
@@ -101,6 +102,7 @@ public CalciteWindowQueryTest(
@SuppressWarnings("unchecked")
public void windowQueryTest() throws IOException
{
+ assumeTrue("These tests are only run in sqlCompatible mode!",
NullHandling.sqlCompatible());
Review Comment:
@imply-cheddar - Can you please confirm that its ok to support testing for
window functions in null compatible mode only? It makes sense to me since we're
already trying to move away from the default value mode, so it would be helpful
that new features only support the null compatible mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
