soumyava commented on code in PR #15101:
URL: https://github.com/apache/druid/pull/15101#discussion_r1348246342
##########
processing/src/test/java/org/apache/druid/segment/UnnestStorageAdapterTest.java:
##########
@@ -516,6 +516,30 @@ public void test_not_pushdown_not_filter()
);
}
+ @Test
+ public void testCannotPushdown()
+ {
+ final Filter testQueryFilter = and(ImmutableList.of(
+ not(selector(OUTPUT_COLUMN_NAME, "3")),
+ or(ImmutableList.of(
+ or(ImmutableList.of(
+ selector("newcol", "2"),
+ selector(COLUMNNAME, "2"),
+ and(ImmutableList.of(
+ selector("newcol", "3"),
+ selector(COLUMNNAME, "7")
+ ))
+ )),
+ selector(OUTPUT_COLUMN_NAME, "1")
+ ))
+ ));
+ testComputeBaseAndPostUnnestFilters(
+ testQueryFilter,
Review Comment:
in a sense pushdown is still happening here, albeit not the entire thing.
Would have been good if we can have a filter on an expression involving more
than one column to show that the pushdown in basically nil. But that can be a
bit complicated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
