pranavbhole commented on code in PR #15103:
URL: https://github.com/apache/druid/pull/15103#discussion_r1349412418


##########
extensions-core/lookups-cached-global/src/test/java/org/apache/druid/server/lookup/namespace/cache/JdbcExtractionNamespaceTest.java:
##########
@@ -63,6 +63,9 @@
 import java.util.concurrent.locks.Lock;
 import java.util.concurrent.locks.ReentrantLock;
 
+import static junit.framework.TestCase.assertEquals;
+import static org.junit.Assert.assertTrue;

Review Comment:
   fixed



##########
extensions-core/lookups-cached-global/src/main/java/org/apache/druid/query/lookup/namespace/ExtractionNamespace.java:
##########
@@ -41,4 +41,12 @@ default long getMaxHeapPercentage()
   {
     return -1L;
   }
+
+  // For larger clusters, when they all startup at the same time and have 
lookups in the db,
+  // it overwhelms the database, this allows implementations to introduce a 
jitter, which
+  // should spread out the load.
+  default long getJitter()

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to