adarshsanjeev commented on code in PR #15024:
URL: https://github.com/apache/druid/pull/15024#discussion_r1349497645
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/input/table/RichSegmentDescriptor.java:
##########
@@ -97,23 +122,21 @@ public boolean equals(Object o)
return false;
}
RichSegmentDescriptor that = (RichSegmentDescriptor) o;
- return Objects.equals(fullInterval, that.fullInterval);
+ return Objects.equals(fullInterval, that.fullInterval) &&
Objects.equals(servers, that.servers);
}
@Override
public int hashCode()
{
- return Objects.hash(super.hashCode(), fullInterval);
+ return Objects.hash(super.hashCode(), fullInterval, servers);
}
@Override
public String toString()
{
return "RichSegmentDescriptor{" +
- "fullInterval=" + (fullInterval == null ? getInterval() :
fullInterval) +
- ", interval=" + getInterval() +
- ", version='" + getVersion() + '\'' +
- ", partitionNumber=" + getPartitionNumber() +
+ "fullInterval=" + fullInterval +
Review Comment:
Removed this by mistake, added this back
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1163,14 +1167,67 @@ private QueryKit makeQueryControllerToolKit()
private DataSegmentTimelineView makeDataSegmentTimelineView()
{
+ final SegmentSource includeSegmentSource =
MultiStageQueryContext.getSegmentSources(
+ task.getQuerySpec()
+ .getQuery()
+ .context()
+ );
+
+ final boolean includeRealtime =
SegmentSource.shouldQueryRealtimeServers(includeSegmentSource);
+
return (dataSource, intervals) -> {
- final Collection<DataSegment> dataSegments =
+ final Iterable<ImmutableSegmentLoadInfo> realtimeAndHistoricalSegments;
+
+ // Fetch the realtime segments first, so that we don't miss any segment
if they get handed off between the two
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
