kfaraz commented on code in PR #14407:
URL: https://github.com/apache/druid/pull/14407#discussion_r1349610092
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskLockbox.java:
##########
@@ -889,6 +891,71 @@ public List<TaskLock> findLocksForTask(final Task task)
}
}
+ /**
+ * Finds the active non-revoked REPLACE locks held by the given task.
+ */
+ public Set<ReplaceTaskLock> findReplaceLocksForTask(Task task)
+ {
+ giant.lock();
+ try {
+ return getNonRevokedReplaceLocks(findLockPossesForTask(task),
task.getDataSource());
+ }
+ finally {
+ giant.unlock();
+ }
+ }
+
+ /**
+ * Finds all the active non-revoked REPLACE locks for the given datasource.
+ */
+ public Set<ReplaceTaskLock> getAllReplaceLocksForDatasource(String
datasource)
+ {
+ giant.lock();
+ try {
+ final NavigableMap<DateTime, SortedMap<Interval, List<TaskLockPosse>>>
activeLocks = running.get(datasource);
+ if (activeLocks == null) {
+ return ImmutableSet.of();
+ }
+
+ List<TaskLockPosse> lockPosses
+ = activeLocks.values()
+ .stream()
+ .flatMap(map -> map.values().stream())
+ .flatMap(Collection::stream)
+ .collect(Collectors.toList());
+ return getNonRevokedReplaceLocks(lockPosses, datasource);
+ }
+ finally {
+ giant.unlock();
+ }
+ }
+
+ private Set<ReplaceTaskLock> getNonRevokedReplaceLocks(List<TaskLockPosse>
posses, String datasource)
+ {
+ final Set<ReplaceTaskLock> replaceLocks = new HashSet<>();
+ for (TaskLockPosse posse : posses) {
+ final TaskLock lock = posse.getTaskLock();
+ if (lock.isRevoked() ||
!TaskLockType.REPLACE.equals(posse.getTaskLock().getType())) {
+ continue;
+ }
+
+ // Replace locks are always held by the supervisor task
+ if (posse.taskIds.size() > 1) {
+ throw new ISE(
+ "Replace lock[%s] for datasource[%s] is held by multiple
tasks[%s]",
+ lock, datasource, posse.taskIds
+ );
Review Comment:
Yeah, this was probably copied over from old code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
