cryptoe commented on code in PR #15093: URL: https://github.com/apache/druid/pull/15093#discussion_r1349929745
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java: ########## @@ -121,6 +125,11 @@ public class MultiStageQueryContext public static final String CTX_INDEX_SPEC = "indexSpec"; public static final String CTX_USE_AUTO_SCHEMAS = "useAutoColumnSchemas"; + public static final boolean DEFAULT_USE_AUTO_SCHEMAS = false; + + public static final String CTX_ARRAY_INGEST_MODE = "arrayIngestMode"; + public static final ArrayIngestMode DEFAULT_ARRAY_INGEST_MODE = ArrayIngestMode.NONE; Review Comment: IMHO we cannot break user's ingestion sql query so I propose the mode should be MVD. The patch should also throw a warning from the controller and throw it on the console if a row signature with Array is detected. The warning clearly lays out the path of migration. There are lot of layers build out in organizations. A change even if its adding a context flag to sometimes takes weeks to reach to production. With this warning we effectively nudge the user that we are going to break compatibility soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
