rohangarg commented on code in PR #15095:
URL: https://github.com/apache/druid/pull/15095#discussion_r1354590153
##########
sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/EarliestLatestAnySqlAggregator.java:
##########
@@ -313,12 +328,48 @@ public RelDataType inferReturnType(SqlOperatorBinding
sqlOperatorBinding)
}
}
+ private static class TimeColIdentifer extends SqlIdentifier
+ {
+
+ public TimeColIdentifer()
+ {
+ super("__time", SqlParserPos.ZERO);
+ }
+
+ @Override
+ public <R> R accept(SqlVisitor<R> visitor)
Review Comment:
doubt : why are we implementing the `accept` method for the custom
Identifier object instead of the `validate` method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
