github-code-scanning[bot] commented on code in PR #15086:
URL: https://github.com/apache/druid/pull/15086#discussion_r1355278567
##########
sql/src/test/java/org/apache/druid/sql/calcite/BaseCalciteQueryTest.java:
##########
@@ -1382,58 +1521,82 @@
* expected results: let the test fail with empty results. The actual results
* are printed to the console. Copy them into the test.
*/
- public static void displayResults(String name, List<Object[]> results)
- {
- PrintStream out = System.out;
- out.printf(Locale.ENGLISH, "-- %s results --", name);
- for (int rowIndex = 0; rowIndex < results.size(); rowIndex++) {
- printArray(results.get(rowIndex), out);
- if (rowIndex < results.size() - 1) {
- out.print(",");
- }
- out.println();
- }
- out.println("----");
- }
-
- private static void printArray(final Object[] array, final PrintStream out)
+ public static String resultsToString(String name, List<Object[]> results)
{
- printArrayImpl(array, out, "new Object[]{", "}");
+ return new ResultsPrinter(name, results).getResult();
}
- private static void printList(final List<?> list, final PrintStream out)
+ static class ResultsPrinter
{
- printArrayImpl(list.toArray(new Object[0]), out, "ImmutableList.of(", ")");
- }
+ private StringBuilder sb;
- private static void printArrayImpl(final Object[] array, final PrintStream
out, final String pre, final String post)
- {
- out.print(pre);
- for (int colIndex = 0; colIndex < array.length; colIndex++) {
- Object col = array[colIndex];
- if (colIndex > 0) {
- out.print(", ");
+ private ResultsPrinter(String name, List<Object[]> results)
+ {
+ sb = new StringBuilder();
+ sb.append("-- " + name + " results --\n");
+
+ for (int rowIndex = 0; rowIndex < results.size(); rowIndex++) {
+ printArray(results.get(rowIndex));
+ if (rowIndex < results.size() - 1) {
+ outprint(",");
+ }
+ sb.append('\n');
}
- if (col == null) {
- out.print("null");
- } else if (col instanceof String) {
- out.print("\"");
- out.print(StringEscapeUtils.escapeJava((String) col));
- out.print("\"");
- } else if (col instanceof Long) {
- out.print(col);
- out.print("L");
- } else if (col instanceof Double) {
- out.print(col);
- out.print("D");
- } else if (col instanceof Object[]) {
- printArray(array, out);
- } else if (col instanceof List) {
- printList((List<?>) col, out);
- } else {
- out.print(col);
+ sb.append("----");
+ }
+
+ private String getResult()
+ {
+ return sb.toString();
+ }
+
+ private void printArray(final Object[] array)
+ {
+ printArrayImpl(array, "new Object[]{", "}");
+ }
+
+ private void printList(final List<?> list)
+ {
+ printArrayImpl(list.toArray(new Object[0]), "ImmutableList.of(", ")");
+ }
+
+ private void printArrayImpl(final Object[] array, final String pre, final
String post)
+ {
+ sb.append(pre);
+ for (int colIndex = 0; colIndex < array.length; colIndex++) {
+ Object col = array[colIndex];
+ if (colIndex > 0) {
+ sb.append(", ");
+ }
+ if (col == null) {
Review Comment:
## Chain of 'instanceof' tests
This if block performs a chain of 6 type tests - consider alternatives, e.g.
polymorphism or the visitor pattern.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5886)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
