clintropolis opened a new pull request, #15135: URL: https://github.com/apache/druid/pull/15135
### Description Fixes an issue semi related to #15058, but this dealing specifically with boolean constant expressions, where boolean constants in the SQL layer were effectively not allowed to be null. The result was incorrect behavior from a query like: <img width="673" alt="Screenshot 2023-10-10 at 11 40 15 PM" src="https://github.com/apache/druid/assets/1577461/87102b23-0da9-4a9d-a281-df866c1a4d9c";> even if `druid.expressions.useStrictBooleans` was set to true. I've modified `DruidLogicalValuesRule` to check for null values on BOOLEAN types, but only if `druid.expressions.useStrictBooleans=true`, resulting in the previous query now producing correct results: <img width="654" alt="Screenshot 2023-10-10 at 11 38 12 PM" src="https://github.com/apache/druid/assets/1577461/a8058faa-a67f-4cf4-94fb-e4d6b9eea7b3";> This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
