kfaraz commented on code in PR #15039: URL: https://github.com/apache/druid/pull/15039#discussion_r1356673026
########## server/src/main/java/org/apache/druid/segment/realtime/appenderator/SinkQuerySegmentWalker.java: ########## @@ -92,6 +94,8 @@ public class SinkQuerySegmentWalker implements QuerySegmentWalker private final Cache cache; private final CacheConfig cacheConfig; private final CachePopulatorStats cachePopulatorStats; + private final ConcurrentMap<SegmentDescriptor, SegmentDescriptor> newIdToBasePendingSegment Review Comment: I don't see items ever being removed from this map. But I guess that will never be needed? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
