abhishekagarwal87 commented on code in PR #14987:
URL: https://github.com/apache/druid/pull/14987#discussion_r1356730994
##########
processing/src/main/java/org/apache/druid/math/expr/FunctionalExpr.java:
##########
@@ -186,7 +187,15 @@ public String toString()
@Override
public ExprEval eval(ObjectBinding bindings)
{
- return function.apply(args, bindings);
+ try {
+ return function.apply(args, bindings);
+ }
+ catch (DruidException | ExpressionValidationException e) {
+ throw e;
+ }
+ catch (Exception e) {
+ throw DruidException.defensive().build(e, "Invocation of function '%s'
encountered exception.", name);
Review Comment:
It should surface as runtime_failure IMO. Both defensive and runtime_failure
map to same error code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
