LakshSingla opened a new pull request, #15183:
URL: https://github.com/apache/druid/pull/15183
### Description
Currently, when reading values from an external data source (`EXTERN`), we
don't cast the values to the signature passed by the user. This can cause an
issue when reading values that are not casted by the underlying selectors.
For example, when reading a boolean array [true, false], we may run into a
bug where the array is not casted to `ARRAY<LONG>` (internal representation for
boolean) by the underlying selector, we pass it to methods assuming the
`getObject()` returns a valid array type (Object[] with long values). Therefore
it's important to cast the externally read values to the row signature passed
by the user. This PR addresses the issue and preserves the type that is entered
by the user in the query, regardless of what gets read.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
