clintropolis opened a new pull request, #15190:
URL: https://github.com/apache/druid/pull/15190
### Description
Follow up to #15127, where I incorrectly advised during review to make
arrays not translate `null` into `"null"` in `Rows.objectToStrings`, but forgot
that stuff was counting on this behavior (however incorrect it may be).
`Rows.toGroupKey` copies the output of `getDimension` into an
`ImmutableSortedSet`, so this change can cause ingestion tasks with null array
elements to fail with an error like:
```
java.lang.NullPointerException: at index 0
at
com.google.common.collect.ObjectArrays.checkElementNotNull(ObjectArrays.java:229)
~[guava-31.1-jre.jar:?]
at
com.google.common.collect.ObjectArrays.checkElementsNotNull(ObjectArrays.java:219)
~[guava-31.1-jre.jar:?]
at
com.google.common.collect.ImmutableSortedSet.construct(ImmutableSortedSet.java:372)
~[guava-31.1-jre.jar:?]
at
com.google.common.collect.ImmutableSortedSet.copyOf(ImmutableSortedSet.java:309)
~[guava-31.1-jre.jar:?]
at
com.google.common.collect.ImmutableSortedSet.copyOf(ImmutableSortedSet.java:329)
~[guava-31.1-jre.jar:?]
at
com.google.common.collect.ImmutableSortedSet.copyOf(ImmutableSortedSet.java:250)
~[guava-31.1-jre.jar:?]
at org.apache.druid.data.input.Rows.toGroupKey(Rows.java:54)
~[classes/:?]
at
org.apache.druid.indexing.common.task.batch.parallel.PartialDimensionDistributionTask$DedupInputRowFilter.accept(PartialDimensionDistributionTask.java:402)
~[classes/:?]
```
This PR has:
- [x] been self-reviewed.
- [x] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [x] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [x] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
