vtlim commented on code in PR #425: URL: https://github.com/apache/druid-website-src/pull/425#discussion_r1366227639
########## scripts/build_docs.py: ########## @@ -28,6 +28,10 @@ def build_docs(versions, use_yarn): + # define the folders that Docusaurus builds into and a temporary one Review Comment: I just moved this to the top of the function, and gave it more descriptive names. We didn't need to reassign the variable at each iteration of the for loop. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
