clintropolis opened a new pull request, #15236: URL: https://github.com/apache/druid/pull/15236
### Description Fixes an issue with #14919 not properly cleaning up the files it creates by explicitly deleting them on calling `close()` of the `DictionaryIdLookup`. Doing it this way also ensures that they only exist as long as they are needed, and is already where we close the mapped buffers, so should be adequate. There is another problem in that this (and incremental segment merging) are using `java.io.tmpdir` rather than the task temporary storage location, however I will fix those issues in a separate PR. I have prepared `DictionaryIdLookup` for this to happen by making it accept a `Path` parameter specifying the temp location (which also made writing tests a bit easier..). This PR has: - [x] been self-reviewed. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
