xvrl commented on code in PR #15106:
URL: https://github.com/apache/druid/pull/15106#discussion_r1370834075
##########
.github/workflows/static-checks.yml:
##########
@@ -51,12 +51,33 @@ jobs:
with:
distribution: 'zulu'
java-version: ${{ matrix.java }}
- cache: 'maven'
+
+ - name: restore maven dependencies
+ # restore maven dependencies only. 'depsonly' keys are safe to restore
+ # since they don't contain any artifacts created by mvn install
+ - uses: actions/cache/restore@v3
+ with:
+ key: maven-${{ runner.os }}-depsonly-${{ hashFiles('**/pom.xml') }}
+ path: ~/.m2/repository
+ restore-keys: |
+ maven-${{ runner.os }}-depsonly-
+
+ - name: compile and cache maven dependencies
+ # run maven compile step to cache all shared maven dependencies
+ # maven install will be run in a subsequent step to avoid polluting
the global maven cache
Review Comment:
if we also want to be able to cache things like npm for the web console like
you suggested, then we will need to rely on a compile/test-compile step to get
all the cache entries warmed up. Without that we cannot guarantee that all
plugins will be downloaded or invoked to pull their dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
