github-advanced-security[bot] commented on code in PR #15257:
URL: https://github.com/apache/druid/pull/15257#discussion_r1372127465
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/QuantilesSketchKeyCollectorFactory.java:
##########
@@ -126,22 +127,66 @@
}
@Override
- public byte[][] deserializeFromMemory(final Memory mem, final int numItems)
+ public byte[][] deserializeFromMemory(final Memory mem, long offsetBytes,
final int numItems)
{
final byte[][] keys = new byte[numItems][];
- long keyPosition = (long) Integer.BYTES * numItems;
+ final long start = offsetBytes;
+ offsetBytes += (long) Integer.BYTES * numItems;
for (int i = 0; i < numItems; i++) {
- final int keyLength = mem.getInt((long) Integer.BYTES * i);
+ final int keyLength = mem.getInt(start + Integer.BYTES * i);
Review Comment:
## Result of multiplication cast to wider type
Potential overflow in [int multiplication](1) before it is converted to long
by use in a numeric context.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5930)
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/statistics/QuantilesSketchKeyCollectorFactory.java:
##########
@@ -126,22 +127,66 @@
}
@Override
- public byte[][] deserializeFromMemory(final Memory mem, final int numItems)
+ public byte[][] deserializeFromMemory(final Memory mem, long offsetBytes,
final int numItems)
{
final byte[][] keys = new byte[numItems][];
- long keyPosition = (long) Integer.BYTES * numItems;
+ final long start = offsetBytes;
+ offsetBytes += (long) Integer.BYTES * numItems;
for (int i = 0; i < numItems; i++) {
- final int keyLength = mem.getInt((long) Integer.BYTES * i);
+ final int keyLength = mem.getInt(start + Integer.BYTES * i);
final byte[] keyBytes = new byte[keyLength];
- mem.getByteArray(keyPosition, keyBytes, 0, keyLength);
+ mem.getByteArray(offsetBytes, keyBytes, 0, keyLength);
keys[i] = keyBytes;
- keyPosition += keyLength;
+ offsetBytes += keyLength;
}
return keys;
}
+
+ @Override
+ public byte[] serializeToByteArray(final byte[] item)
+ {
+ final byte[] bytes = new byte[Integer.BYTES + item.length];
+ ByteArrayUtil.putIntLE(bytes, 0, item.length);
+ ByteArrayUtil.copyBytes(item, 0, bytes, Integer.BYTES, item.length);
+ return bytes;
+ }
+
+ @Override
+ public byte[][] deserializeFromMemory(final Memory mem, final int numItems)
+ {
+ return deserializeFromMemory(mem, 0, numItems);
+ }
+
+ @Override
+ public int sizeOf(final byte[] item)
+ {
+ return Integer.BYTES + item.length;
+ }
+
+ @Override
+ public int sizeOf(final Memory mem, long offsetBytes, final int numItems)
+ {
+ int length = Integer.BYTES * numItems;
+ for (int i = 0; i < numItems; i++) {
+ length = mem.getInt(offsetBytes + Integer.BYTES * i);
Review Comment:
## Result of multiplication cast to wider type
Potential overflow in [int multiplication](1) before it is converted to long
by use in a numeric context.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5931)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
