AmatyaAvadhanula commented on code in PR #15274:
URL: https://github.com/apache/druid/pull/15274#discussion_r1375777125
##########
server/src/main/java/org/apache/druid/server/http/DataSourcesResource.java:
##########
@@ -873,16 +872,14 @@ public Response isHandOffComplete(
final DateTime now = DateTimes.nowUtc();
// A segment that is not eligible for load will never be handed off
- boolean notEligibleForLoad = true;
+ boolean eligibleForLoad = false;
for (Rule rule : rules) {
if (rule.appliesTo(theInterval, now)) {
- if (rule instanceof LoadRule) {
- notEligibleForLoad = false;
- }
+ eligibleForLoad = rule.shouldSegmentBeLoaded();
break;
Review Comment:
Apologies, I had assumed wrongly that the check was on tier-wise basis, but
a single rule has the replication factor for all the tiers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
