LakshSingla commented on code in PR #15301:
URL: https://github.com/apache/druid/pull/15301#discussion_r1378668141
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/scan/ScanQueryFrameProcessor.java:
##########
@@ -172,13 +174,26 @@ public static Sequence<Object[]>
mappingFunction(Sequence<ScanResultValue> input
}).map(List::toArray);
}
+ private static ScanQuery prepareScanQuery(@NotNull ScanQuery scanQuery)
+ {
+ if (ScanQuery.Order.NONE.equals(scanQuery.getTimeOrder())) {
Review Comment:
I think we can optimize this further - Consider if we have a scan query
without any ordering but with a limit. In that case, we don't need to set the
limit to 0 to fetch the results. We can keep the limit as is.
Therefore instead of checking the timeOrder, we'd also need to check the
ordering inside, and if its empty or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
