techdocsmith commented on code in PR #14964: URL: https://github.com/apache/druid/pull/14964#discussion_r1380615588
########## docs/operations/basic-cluster-tuning.md: ########## @@ -90,7 +90,7 @@ Tuning the cluster so that each Historical can accept 50 queries and 10 non-quer #### Segment Cache Size -For better query performance, do not allocate segment data to a Historical in excess of the system free memory. When `free system memory` is greater than or equal to `druid.segmentCache.locations`, the more segment data the Historical can be held in the memory-mapped segment cache. +For better query performance, do not allocate segment data to a Historical in excess of the system free memory. When `free system memory` is greater than or equal to `druid.segmentCache.locations`, the Historical's memory-mapped segment cache can be held in memory, rather than being paged to disk. Review Comment: ```suggestion For better query performance, do not allocate segment data to a Historical in excess of the system free memory. When `free system memory` is greater than or equal to `druid.segmentCache.locations`, the Historical's entire memory-mapped segment cache can be held in memory. For more detail, see [Loading and serving segments from cache](../design/historical/#loading-and-serving-segments-from-cache) ``` @kfaraz , does this correct the ambiguity? ########## docs/operations/basic-cluster-tuning.md: ########## @@ -90,7 +90,7 @@ Tuning the cluster so that each Historical can accept 50 queries and 10 non-quer #### Segment Cache Size -For better query performance, do not allocate segment data to a Historical in excess of the system free memory. When `free system memory` is greater than or equal to `druid.segmentCache.locations`, the more segment data the Historical can be held in the memory-mapped segment cache. +For better query performance, do not allocate segment data to a Historical in excess of the system free memory. When `free system memory` is greater than or equal to `druid.segmentCache.locations`, the Historical's memory-mapped segment cache can be held in memory, rather than being paged to disk. Druid uses the `druid.segmentCache.locations` to calculate the total segment data size assigned to a Historical. For some rarer use cases, you can override this behavior with `druid.server.maxSize` property. Review Comment: ```suggestion Druid uses the `druid.segmentCache.locations` to calculate the total segment data size assigned to a Historical. For rare use cases, you can override this behavior with `druid.server.maxSize` property. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
