clintropolis opened a new pull request, #15321:
URL: https://github.com/apache/druid/pull/15321
### Description
This PR fixes auto-compaction to properly preserve spatial dimensions. Prior
to this fix, spatial dimensions would be rewritten into regular string
dimensions, losing their spatial indexes.
I went back and tested stuff versions over the last few years, and all of
them had this flaw, at least for as far back as I went. It seems plausible that
auto compaction has never supported spatial dimensions - which isn't
particularly surprising since they are not commonly used afaik, at least I
haven't seen them much, and are not supported in SQL.
I personally think spatial dimensions would be a lot better suited to be
modernized as a complex dimension instead of piggy-backing off of strings, but
that said, using compaction on them shouldn't destroy them if you went to the
trouble of creating them in the first place.
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
