abhishekagarwal87 commented on code in PR #15334: URL: https://github.com/apache/druid/pull/15334#discussion_r1384366165
########## docs/design/metadata-storage.md: ########## @@ -44,7 +44,9 @@ See [Metadata storage configuration](../configuration/index.md#metadata-storage) ## Available metadata stores -Druid supports Derby, MySQL, and PostgreSQL for storing metadata. +Druid supports Derby, MySQL, and PostgreSQL for storing metadata. + +To avoid issues with upgrades that require scehma changes to a large metadata table, chose a metadata store version that supports instant ADD COLUMN semantics. Review Comment: Can you also add to see the database-specific docs on any specific guidance about versions? Also, we should say "prefer' instead of 'chose'. ########## docs/development/extensions-core/mysql.md: ########## @@ -61,6 +61,8 @@ Depending on the MariaDB client library version, the connector supports both `jd ## Setting up MySQL +To avoid issues with upgrades that require scehma changes to a large metadata table, chose a MySQL version that supports instant ADD COLUMN semantics. For example, MySQL 8. Review Comment: can we add a similar bit about postgres? We can just say that postgres supports instant add already but please double check anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
