clintropolis opened a new pull request, #15350:
URL: https://github.com/apache/druid/pull/15350
### Description
Array element indexes are already hiding inside of array type columns, this
PR adds a native `array_contains` filter so we can actually use them. Will
update PR with performance measurements once I have the chance to actually do
them.
I did consider just making a native "array element" filter that would only
match if the array contains the match value, instead of the way
`array_contains` handles arrays, where it matches if all elements in the array
to match against are contained in the array being matched, and having the SQL
planner use an external AND filter to implement something like
`ARRAY_CONTAINS(arrayColumn, ARRAY[1,2,3])`. We could consider taking that
approach instead, but on the other hand, we can still implement `ARRAY_OVERLAP`
using this filter as is by breaking up array elements into separate native
array contains filters and using an or filter to combine them.
No documentation currently added, will do that in a follow-up PR.
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not
all of these items apply to every PR. Remove the items which are not done or
not relevant to the PR. None of the items from the checklist below are strictly
necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
