BartMiki commented on code in PR #15363:
URL: https://github.com/apache/druid/pull/15363#discussion_r1390820772
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -170,10 +184,242 @@
</dependencies>
<profiles>
<profile>
- <id>hadoop3</id>
+ <id>hadoop2</id>
Review Comment:
Drop that, Hadoop 2 is deprecated and should not be part of this extension
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -211,6 +457,47 @@
</usedDependencies>
</configuration>
</plugin>
+ <plugin>
Review Comment:
Remove the build plugin, it was needed to build the extension separately
from Druid, it will be built as part of Druid now
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -185,7 +431,7 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-client-runtime</artifactId>
<version>${hadoop.compile.version}</version>
- <scope>runtime</scope>
+ <scope>test</scope>
Review Comment:
Don't change the scope
##########
extensions-core/druid-ranger-security/pom.xml:
##########
@@ -34,6 +34,10 @@
<relativePath>../../pom.xml</relativePath>
</parent>
+ <properties>
Review Comment:
You should change that in the master pom.xml of Druid, not here, it should
be removed from here
##########
extensions-core/druid-ranger-security/src/assembly/assembly.xml:
##########
Review Comment:
Remove this whole file, it was for building extension separately from Druid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
