adarshsanjeev commented on code in PR #15336:
URL: https://github.com/apache/druid/pull/15336#discussion_r1387877241
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -5269,44 +5267,6 @@ public void testSqlIsNullToInFilter()
);
}
- @Test
- public void testInFilterWith23Elements()
Review Comment:
`org.apache.druid.sql.calcite.CalciteQueryTest#testPlanWithInFilterLessThanInSubQueryThreshold`
and
`org.apache.druid.sql.calcite.CalciteJoinQueryTest#testPlanWithInFilterMoreThanInSubQueryThreshold`
should cover both sides of this.
The comment in this test implies that it was for a particular issue when
druid did not support joins. Is there a reason to keep it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
