This is an automated email from the ASF dual-hosted git repository.
abhishekrb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 06744d3827c Changing a string to key:value pair to fix flakiness in
`testSerializationWithDefaults` (#15317)
06744d3827c is described below
commit 06744d3827c76617f40b0da2f73b3445853c0b4a
Author: Krishna Anandan <[email protected]>
AuthorDate: Tue Nov 14 17:59:07 2023 -0600
Changing a string to key:value pair to fix flakiness in
`testSerializationWithDefaults` (#15317)
* + Fix for Flaky Test
* + Replacing TreeMap with LinkedHashMap
* + Changing data structure from LinkedHashMap to HashMap
* Fixed flaky test in
S3DataSegmentPusherConfigTest.testSerializationValidatingMaxListingLength
* Minor Changes
---
.../org/apache/druid/storage/s3/S3DataSegmentPusherConfigTest.java | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
a/extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3DataSegmentPusherConfigTest.java
b/extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3DataSegmentPusherConfigTest.java
index c35733618a7..bf5f07efb93 100644
---
a/extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3DataSegmentPusherConfigTest.java
+++
b/extensions-core/s3-extensions/src/test/java/org/apache/druid/storage/s3/S3DataSegmentPusherConfigTest.java
@@ -29,6 +29,7 @@ import javax.validation.ConstraintViolation;
import javax.validation.Validation;
import javax.validation.Validator;
import java.io.IOException;
+import java.util.Map;
import java.util.Set;
public class S3DataSegmentPusherConfigTest
@@ -51,9 +52,10 @@ public class S3DataSegmentPusherConfigTest
String jsonConfig = "{\"bucket\":\"bucket1\",\"baseKey\":\"dataSource1\"}";
String expectedJsonConfig =
"{\"bucket\":\"bucket1\",\"baseKey\":\"dataSource1\","
+
"\"disableAcl\":false,\"maxListingLength\":1024,\"useS3aSchema\":false}";
-
S3DataSegmentPusherConfig config = JSON_MAPPER.readValue(jsonConfig,
S3DataSegmentPusherConfig.class);
- Assert.assertEquals(expectedJsonConfig,
JSON_MAPPER.writeValueAsString(config));
+ Map<String, String> expected = JSON_MAPPER.readValue(expectedJsonConfig,
Map.class);
+ Map<String, String> actual =
JSON_MAPPER.readValue(JSON_MAPPER.writeValueAsString(config), Map.class);
+ Assert.assertEquals(expected, actual);
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
