kfaraz commented on PR #15116: URL: https://github.com/apache/druid/pull/15116#issuecomment-1813718691
@dulu98Kurz , thanks for attempting to fix this! As @AmatyaAvadhanula points out, there are other concerns in just changing this `short` to `int`. Similarly, truncating the values to ensure that overflow never happens is not the right approach either. Issue https://github.com/apache/druid/issues/15356 has been created to discuss a more long-term solution for this. For now, I think the best approach for your PR would be to ensure fail fast in such cases and give a better error message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
