abhishekrb19 commented on code in PR #15374:
URL: https://github.com/apache/druid/pull/15374#discussion_r1396230361
##########
extensions-core/avro-extensions/src/test/java/org/apache/druid/data/input/AvroStreamInputRowParserTest.java:
##########
@@ -301,7 +301,7 @@ public void testParseSchemaless() throws
SchemaValidationException, IOException
static void assertInputRowCorrect(InputRow inputRow, List<String>
expectedDimensions, boolean isFromPigAvro)
{
- Assert.assertEquals(expectedDimensions, inputRow.getDimensions());
+ Assert.assertEquals(new HashSet<>(expectedDimensions), new
HashSet<>(inputRow.getDimensions()));
Review Comment:
@krishnanand5, this would make sense for schemaless tests where the order is
non-deterministic when dimension spec is `DimensionsSpec.EMPTY`. On the other
hand, when a non-empty schema is specified in the parse spec, order of these
dimensions is important and should match the parse spec, so we should assert
the lists as-is.
So I'd suggest passing in `DimensionSpec` to this function and do a
conditional assert based on `DimensionsSpec.EMPTY`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
