abhishekrb19 commented on code in PR #15379:
URL: https://github.com/apache/druid/pull/15379#discussion_r1396744153
##########
server/src/test/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinatorTest.java:
##########
@@ -2907,6 +2909,79 @@ public void
testRetrieveUsedSegmentsAndCreatedDatesFetchesEternityForAnyInterval
Assert.assertEquals(3, resultForEternity.size());
}
+ @Test
+ public void testTimelineWithTombstoneCorePartitionsAs0() throws IOException
+ {
+ final Interval interval = Intervals.of("2020/2021");
+ // Create and commit a tombstone segment
+ final DataSegment tombstoneSegment = createSegment(
+ interval,
+ "version",
+ new TombstoneShardSpec()
+ );
+
+ final Set<DataSegment> tombstones = new
HashSet<>(Collections.singleton(tombstoneSegment));
+
Assert.assertTrue(coordinator.commitSegments(tombstones).containsAll(tombstones));
+
+ // Create and commit a data segment
+ final DataSegment dataSegment = createSegment(
Review Comment:
Thanks. Added allocate pending segment and commit for the data segment. Kept
it as two separate tests still since the old generation tombstones (with 1 core
partition) have been around for awhile, so the test behavior shows what to
expect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
