github-advanced-security[bot] commented on code in PR #15398:
URL: https://github.com/apache/druid/pull/15398#discussion_r1398657614
##########
extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleTaskLogsTest.java:
##########
@@ -379,29 +377,29 @@
EasyMock.expect(inputDataConfig.getMaxListingLength()).andReturn(MAX_KEYS);
- EasyMock.replay(listRequest, inputDataConfig, storage);
+ EasyMock.replay(inputDataConfig, storage);
googleTaskLogs.killOlderThan(TIME_NOW);
- EasyMock.verify(listRequest, inputDataConfig, storage);
+ EasyMock.verify(inputDataConfig, storage);
}
@Test
public void
test_killOlderThan_nonrecoverableExceptionWhenListingObjects_doesntDeleteAnyTaskLogs()
{
boolean ioExceptionThrown = false;
- Storage.Objects.List listRequest = null;
+ GoogleStorage.GoogleStorageObjectPage objectsPage = null;
Review Comment:
## Unread local variable
Variable 'GoogleStorageObjectPage objectsPage' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5986)
##########
extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleDataSegmentKillerTest.java:
##########
@@ -224,30 +225,30 @@
EasyMock.expect(accountConfig.getPrefix()).andReturn(PREFIX).anyTimes();
EasyMock.expect(inputDataConfig.getMaxListingLength()).andReturn(MAX_KEYS);
- EasyMock.replay(listRequest, accountConfig, inputDataConfig, storage);
+ EasyMock.replay(accountConfig, inputDataConfig, storage);
GoogleDataSegmentKiller killer = new GoogleDataSegmentKiller(storage,
accountConfig, inputDataConfig);
killer.killAll();
- EasyMock.verify(listRequest, accountConfig, inputDataConfig, storage);
+ EasyMock.verify(accountConfig, inputDataConfig, storage);
}
@Test
public void
test_killAll_nonrecoverableExceptionWhenListingObjects_doesntDeleteAnyTaskLogs()
{
boolean ioExceptionThrown = false;
- Storage.Objects.List listRequest = null;
+ GoogleStorage.GoogleStorageObjectPage objectPage = null;
Review Comment:
## Unread local variable
Variable 'GoogleStorageObjectPage objectPage' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5984)
##########
extensions-core/google-extensions/src/test/java/org/apache/druid/storage/google/GoogleTaskLogsTest.java:
##########
@@ -282,31 +280,31 @@
EasyMock.expect(inputDataConfig.getMaxListingLength()).andReturn(MAX_KEYS);
- EasyMock.replay(listRequest, inputDataConfig, storage, timeSupplier);
+ EasyMock.replay(inputDataConfig, storage, timeSupplier);
googleTaskLogs.killAll();
- EasyMock.verify(listRequest, inputDataConfig, storage, timeSupplier);
+ EasyMock.verify(inputDataConfig, storage, timeSupplier);
}
@Test
public void
test_killAll_nonrecoverableExceptionWhenListingObjects_doesntDeleteAnyTaskLogs()
{
boolean ioExceptionThrown = false;
- Storage.Objects.List listRequest = null;
+ GoogleStorage.GoogleStorageObjectPage objectsPage = null;
Review Comment:
## Unread local variable
Variable 'GoogleStorageObjectPage objectsPage' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/5985)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
