kgyrtkirk commented on code in PR #15365:
URL: https://github.com/apache/druid/pull/15365#discussion_r1400104358
##########
processing/src/main/java/org/apache/druid/query/operator/window/WindowFrame.java:
##########
@@ -44,21 +49,35 @@ public enum PeerType
private final int lowerOffset;
private final boolean upperUnbounded;
private final int upperOffset;
+ private final List<ColumnWithDirection> orderBy;
+
+
+ public WindowFrame(
+ PeerType peerType,
+ boolean lowerUnbounded,
+ int lowerOffset,
+ boolean upperUnbounded,
+ int upperOffset)
+ {
+ this(peerType, lowerUnbounded, lowerOffset, upperUnbounded, upperOffset,
null);
+ }
Review Comment:
sure - I can reduce the number of constructors; but in this case I would
also remove the extra boolean for the presence of lower/upper; as it just
bloats the json representation....possible alternatives could be to use:
* custom reader/writer
* or...use integer and treat `null` as unbounded
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
