kfaraz commented on code in PR #15424:
URL: https://github.com/apache/druid/pull/15424#discussion_r1404125997
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3357,22 +3327,18 @@ public Map<PartitionIdType, SequenceOffsetType>
apply(List<Either<Throwable, Map
log.info("Successfully set endOffsets for task[%s] and
resumed it", setEndOffsetTaskIds.get(i));
} else {
String taskId = setEndOffsetTaskIds.get(i);
- killTask(
- taskId,
- "Task [%s] failed to respond to [set end offsets] in a
timely manner, killing task",
- taskId
- );
+ killTask(taskId, "Failed to set end offsets, killing task");
Review Comment:
I don't feel so as this message will always be used in the context of this
task id (say while displaying reason for failure on the web console).
In fact, I think we should get rid of the task id from all such kill
messages (in a separate PR) as it is redundant. Removing it will simplify the
failure message.
(side benefit: significantly reduced cardinality if we emit the failure
reason as a dimension atleast until we have error codes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
