gianm commented on code in PR #15452:
URL: https://github.com/apache/druid/pull/15452#discussion_r1411228542
##########
processing/src/main/java/org/apache/druid/segment/transform/RowFunction.java:
##########
@@ -30,5 +31,9 @@ public interface RowFunction
{
Object eval(Row row);
- List<String> evalDimension(Row row);
+ default List<String> evalDimension(Row row)
+ {
+ Object value = eval(row);
+ return Collections.singletonList(value == null ? null :
String.valueOf(value));
Review Comment:
I think `Rows.objectToStrings(eval(row))` would be more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
