xvrl commented on code in PR #15482:
URL: https://github.com/apache/druid/pull/15482#discussion_r1414309009
##########
server/src/test/java/org/apache/druid/metadata/SqlSegmentsMetadataManagerTest.java:
##########
@@ -283,7 +283,9 @@ public void testPollPeriodicallyAndOnDemandInterleave()
throws Exception
Assert.assertTrue(sqlSegmentsMetadataManager.getLatestDatabasePoll()
instanceof SqlSegmentsMetadataManager.PeriodicDatabasePoll);
dataSourcesSnapshot = sqlSegmentsMetadataManager.getDataSourcesSnapshot();
Assert.assertEquals(
- ImmutableList.of("wikipedia3", "wikipedia", "wikipedia2"),
+ // This test is guava version sensitive when upgrading to guava > 32
+ // the order changes to
+ ImmutableList.of("wikipedia2", "wikipedia3", "wikipedia"),
dataSourcesSnapshot.getDataSourcesWithAllUsedSegments()
.stream()
.map(ImmutableDruidDataSource::getName)
Review Comment:
Github won't let me suggest further below in the diff, but let's just remove
the ordering assumptions here.
```suggestion
.map(ImmutableDruidDataSource::getName).collect(Collectors.toSet())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
