github-advanced-security[bot] commented on code in PR #15415:
URL: https://github.com/apache/druid/pull/15415#discussion_r1414427674
##########
server/src/test/java/org/apache/druid/server/http/DataSourcesResourceTest.java:
##########
@@ -586,6 +591,329 @@
EasyMock.verify(inventoryView);
}
+ @Test
+ public void testGetUnusedSegmentIdsInInterval()
+ {
+
EasyMock.expect(segmentsMetadataManager.iterateAllUnusedSegmentsForDatasource(
+ EasyMock.anyString(),
+ EasyMock.anyObject(Interval.class),
+ EasyMock.anyInt(),
+ EasyMock.anyInt()
+ ))
+ .andAnswer(mockIterateAllUnusedSegmentsForDatasource())
+ .atLeastOnce();
+ EasyMock.replay(segmentsMetadataManager);
+
+ DataSourcesResource dataSourcesResource =
+ new DataSourcesResource(null, segmentsMetadataManager, null, null,
null, null);
+
+ // test invalid datasource - returns empty segmentIds
+ Response response = dataSourcesResource.getUnusedSegmentIdsInInterval(
+ "invalidDataSource",
+ null,
+ null,
+ null
+ );
+ Assert.assertEquals(response.getEntity(), ImmutableSet.of());
+
+ // test valid datasource with bad limit - fails with expected bad limit
message
+ DruidException e = Assert.assertThrows(
+ DruidException.class,
+ () -> dataSourcesResource.getUnusedSegmentIdsInInterval(
+ "datasource1",
+ null,
+ -1,
+ null
+ )
+ );
+ Assert.assertEquals(DruidException.Category.INVALID_INPUT,
e.getCategory());
+ Assert.assertEquals(EXPECTED_BAD_LIMIT_MESSAGE, e.getMessage());
+
+ // test valid datasource with bad offset - fails with expected bad offset
message
+ e = Assert.assertThrows(
+ DruidException.class,
+ () -> dataSourcesResource.getUnusedSegmentIdsInInterval(
+ "datasource1",
+ null,
+ null,
+ -1
+ )
+ );
+ Assert.assertEquals(DruidException.Category.INVALID_INPUT,
e.getCategory());
+ Assert.assertEquals(EXPECTED_BAD_OFFSET_MESSAGE, e.getMessage());
+
+
+ // test valid datasource - returns all unused segments for that datasource
+ response = dataSourcesResource.getUnusedSegmentIdsInInterval(
+ "datasource1",
+ null,
+ null,
+ null
+ );
+
+ TreeSet<SegmentId> actualSegmentIds = (TreeSet) response.getEntity();
+ Set<SegmentId> expectedSegmentIds = dataSegmentList.stream()
+ .filter(d -> "datasource1".equals(d.getDataSource()))
+ .map(d -> d.getId())
+ .collect(Collectors.toSet());
+ Assert.assertEquals(expectedSegmentIds, actualSegmentIds);
+
+ // test valid datasource with interval filter - returns all unused
segments for that datasource within interval
+ String interval = "2010-01-01_P1D";
+ Interval theInterval = Intervals.of("2010-01-01_P1D".replace('_', '/'));
+ response = dataSourcesResource.getUnusedSegmentIdsInInterval(
+ "datasource1",
+ interval,
+ null,
+ null
+ );
+
+ actualSegmentIds = (TreeSet) response.getEntity();
+ expectedSegmentIds = dataSegmentList.stream()
+ .filter(d -> "datasource1".equals(d.getDataSource())
+ && theInterval.getStartMillis() >=
d.getInterval().getStartMillis()
+ && theInterval.getEndMillis() <=
d.getInterval().getEndMillis())
+ .map(d -> d.getId())
+ .collect(Collectors.toSet());
+ Assert.assertEquals(expectedSegmentIds, actualSegmentIds);
+
+ EasyMock.verify(segmentsMetadataManager);
+ }
+
+ @Test
+ public void testGetUnusedSegmentsStatsInInterval()
+ {
+
EasyMock.expect(segmentsMetadataManager.iterateAllUnusedSegmentsForDatasource(
+ EasyMock.anyString(),
+ EasyMock.anyObject(Interval.class),
+ EasyMock.anyInt(),
+ EasyMock.anyInt()
+ ))
+ .andAnswer(mockIterateAllUnusedSegmentsForDatasource())
+ .atLeastOnce();
+ EasyMock.replay(segmentsMetadataManager);
+
+ DataSourcesResource dataSourcesResource =
+ new DataSourcesResource(null, segmentsMetadataManager, null, null,
null, null);
+
+ // test invalid datasource - returns empty stats
+ Response response = dataSourcesResource.getUnusedSegmentsStatsInInterval(
+ "invalidDataSource",
+ null,
+ null,
+ null
+ );
+ Assert.assertEquals(response.getEntity(), ImmutableMap.of());
+
+ // test valid datasource with bad limit - fails with expected bad limit
message
+ DruidException e = Assert.assertThrows(
+ DruidException.class,
+ () -> dataSourcesResource.getUnusedSegmentsStatsInInterval(
+ "datasource1",
+ null,
+ -1,
+ null
+ )
+ );
+ Assert.assertEquals(DruidException.Category.INVALID_INPUT,
e.getCategory());
+ Assert.assertEquals(EXPECTED_BAD_LIMIT_MESSAGE, e.getMessage());
+
+ // test valid datasource with bad offset - fails with expected bad offset
message
+ e = Assert.assertThrows(
+ DruidException.class,
+ () -> dataSourcesResource.getUnusedSegmentsStatsInInterval(
+ "datasource1",
+ null,
+ null,
+ -1
+ )
+ );
+ Assert.assertEquals(DruidException.Category.INVALID_INPUT,
e.getCategory());
+ Assert.assertEquals(EXPECTED_BAD_OFFSET_MESSAGE, e.getMessage());
+
+ // test valid datasource - returns stats for all intervals where unused
segments are found, for that datasource
+ response = dataSourcesResource.getUnusedSegmentsStatsInInterval(
+ "datasource1",
+ null,
+ null,
+ null
+ );
+
+ List<Interval> expectedIntervals = new ArrayList<>();
+
expectedIntervals.add(Intervals.of("2010-01-22T00:00:00.000Z/2010-01-23T00:00:00.000Z"));
+
expectedIntervals.add(Intervals.of("2010-01-01T00:00:00.000Z/2010-01-02T00:00:00.000Z"));
+ TreeMap<Interval, Map<DataSourcesResource.SimpleProperties, Object>>
results = (TreeMap) response.getEntity();
+ Assert.assertEquals(2, results.size());
+ List<Interval> intervalsInOrderFromEarliest = expectedIntervals.stream()
+ .sorted((o1, o2) -> Comparators.intervalsByStartThenEnd().compare(o1,
o2))
+ .collect(Collectors.toList());
+ Assert.assertEquals(intervalsInOrderFromEarliest.get(0),
results.firstKey());
+ Assert.assertEquals(intervalsInOrderFromEarliest.get(1),
results.lastKey());
+ Assert.assertEquals(1,
results.firstEntry().getValue().get(DataSourcesResource.SimpleProperties.count));
+ Assert.assertEquals(1,
results.lastEntry().getValue().get(DataSourcesResource.SimpleProperties.count));
+
+ // test valid datasource with interval filter - returns stats for all
intervals, within intercal specified, where
+ // unused segments are found, for that datasource
+ String interval = "2010-01-01_P1D";
+ Interval theInterval = Intervals.of("2010-01-01_P1D".replace('_', '/'));
Review Comment:
## Unread local variable
Variable 'Interval theInterval' is never read.
[Show more
details](https://github.com/apache/druid/security/code-scanning/6024)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
