vogievetsky commented on code in PR #15472:
URL: https://github.com/apache/druid/pull/15472#discussion_r1414634723
##########
web-console/src/druid-models/lookup-spec/lookup-spec.tsx:
##########
@@ -464,30 +464,30 @@ export const LOOKUP_FIELDS: Field<LookupSpec>[] = [
{
name: 'extractionNamespace.jitterSeconds',
type: 'number',
- placeholder: '30 (optional), default is 0',
+ placeholder: '30 (optional) ',
Review Comment:
instead of setting the placeholder this you could just add `defaultValue:
30` this basically sets the placeholder to `30`. The `(optional)` label is not
needed because visually when you open the form and there is a default value
filled in as the placeholder it visually conveys "optional". The placeholder is
really there for when you need to override the default behavior that I don't
think you need to do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
