findingrish opened a new pull request, #15496: URL: https://github.com/apache/druid/pull/15496
### Description With `CentralizedDatasourceSchema` (https://github.com/apache/druid/issues/14989) feature enabled, metadata for appended segments was not being refreshed. This caused `numRows` to be 0 for the new segments and would probably cause the datasource schema to not include columns from the new segments. ### Analysis The problem turned out in the new QuerySegmentWalker implementation in the Coordinator. It first find the segment to be queried in the Coordinator timeline. Then it creates a new timeline of the segments found in the timeline. The problem was that it is looking up complete partition set in the new timeline. Since the appended segments by themselves do not make a complete partition set, thus no SegmentMetadata query was being executed. ### Fix The fix is to lookup incomplete partition set in the new timeline. It is consistent with the logic in `CachingClusteredClient` for querying specific segments (https://github.com/apache/druid/blob/master/server/src/main/java/org/apache/druid/client/CachingClusteredClient.java#L429). This PR has: - [ ] been self-reviewed. - [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] a release note entry in the PR description. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [ ] added integration tests. - [ ] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
