kgyrtkirk commented on code in PR #15371: URL: https://github.com/apache/druid/pull/15371#discussion_r1416863037
########## processing/src/main/java/org/apache/druid/segment/ObjectBasedColumnSelector.java: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.segment; + +import org.apache.druid.error.DruidException; + +/** + * Object based column selector. + * + * This abstract class provides a {@link ColumnValueSelector} based on the methods of {@link BaseObjectColumnValueSelector}. + */ +public abstract class ObjectBasedColumnSelector<T> implements ColumnValueSelector<T> +{ + private static final String COLUMN_IS_NULL_ERROR_MESSAGE = "Invalid usage pattern: method returning primitive called - but the column is null"; + + @Override + public final float getFloat() + { + T value = getObject(); + if (value == null) { + throw DruidException.defensive(COLUMN_IS_NULL_ERROR_MESSAGE); + } + return ((Number) value).floatValue(); + } + + @Override + public final double getDouble() + { + T value = getObject(); + if (value == null) { + throw DruidException.defensive(COLUMN_IS_NULL_ERROR_MESSAGE); + } + return ((Number) value).doubleValue(); + } + + @Override + public final long getLong() + { + T value = getObject(); + if (value == null) { + throw DruidException.defensive(COLUMN_IS_NULL_ERROR_MESSAGE); + } + return ((Number) value).longValue(); + } + + @Override + public final boolean isNull() + { + return getObject() == null; Review Comment: I'm not sure about the added value of such a check as the classcastexception will tell the story pretty nicely where/why the issue happened - but I've added some ifs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
